Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags: check that tags_all is not null #34073

Merged
merged 2 commits into from
Oct 23, 2023
Merged

tags: check that tags_all is not null #34073

merged 2 commits into from
Oct 23, 2023

Conversation

johnsonaj
Copy link
Contributor

Description

Guard against tags_all being null

Relations

Closes #33995

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccVPC_ -short' PKG=vpc

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_ -short -timeout 360m
    vpc_test.go:1021: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv4BasicNetmask (0.00s)
    vpc_test.go:1048: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv4BasicExplicitCIDR (0.00s)
    vpc_test.go:1076: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv6 (0.00s)
=== NAME  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    ec2_availability_zone_data_source_test.go:222: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (1.14s)
--- PASS: TestAccVPC_disappears (117.61s)
--- PASS: TestAccVPC_tags_null (137.96s)
--- PASS: TestAccVPC_basic (145.77s)
--- PASS: TestAccVPC_disabledDNSSupport (153.87s)
--- PASS: TestAccVPC_bothDNSOptionsSet (155.52s)
--- PASS: TestAccVPC_enableNetworkAddressUsageMetrics (155.52s)
--- PASS: TestAccVPC_tags_computed (209.88s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (216.09s)
--- PASS: TestAccVPC_updateDNSHostnames (234.94s)
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (249.18s)
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (274.72s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (296.44s)
--- PASS: TestAccVPC_tags (298.93s)
--- PASS: TestAccVPC_tenancy (302.11s)
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (316.47s)
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (201.36s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (320.02s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (181.90s)
--- PASS: TestAccVPC_ignoreTags (190.07s)
--- PASS: TestAccVPC_DefaultTags_zeroValue (374.31s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (375.70s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (377.56s)
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (377.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	381.268s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 23, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 23, 2023
@johnsonaj johnsonaj added crash Results from or addresses a Terraform crash or kernel panic. tags Pertains to resource tagging. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 23, 2023
ewbankkit
ewbankkit approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

CHANGELOG entry?

jar-b
jar-b approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccVPC_ -short' PKG=vpc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_ -short -timeout 360m

--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (0.86s)
=== CONT  TestAccVPC_DefaultTags_zeroValue
--- PASS: TestAccVPC_disappears (118.66s)
=== CONT  TestAccVPC_tags_null
--- PASS: TestAccVPC_basic (149.79s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_disabledDNSSupport (163.11s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_enableNetworkAddressUsageMetrics (164.22s)
--- PASS: TestAccVPC_bothDNSOptionsSet (164.56s)
--- PASS: TestAccVPC_tags_computed (210.49s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (228.00s)
--- PASS: TestAccVPC_tags_null (129.80s)
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (263.35s)
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (266.77s)
--- PASS: TestAccVPC_ignoreTags (268.40s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (268.94s)
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (285.82s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (301.01s)
--- PASS: TestAccVPC_tags (305.03s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (322.73s)
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (324.45s)
--- PASS: TestAccVPC_updateDNSHostnames (178.32s)
--- PASS: TestAccVPC_tenancy (201.21s)
--- PASS: TestAccVPC_DefaultTags_zeroValue (377.29s)
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (381.63s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (382.00s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (382.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        386.034s

@johnsonaj johnsonaj merged commit 54f4628 into main Oct 23, 2023
32 checks passed
@johnsonaj johnsonaj deleted the b-tags_all_null branch October 23, 2023 20:47
@github-actions github-actions bot added this to the v5.23.0 milestone Oct 23, 2023
github-actions bot pushed a commit that referenced this pull request Oct 23, 2023
Update CHANGELOG.md for #34073
e659dc8
@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet
Milestone
v5.23.0
Development

Successfully merging this pull request may close these issues.

[Bug]: panic: value is null
4 participants
@johnsonaj @ewbankkit @jar-b @justinretzolk